fix: use recent version of EF bootstrap #6608
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Superseded by #6609 (review). |
JakeChampion
approved these changes
Aug 7, 2025
pieh
reviewed
Aug 7, 2025
| @@ -1,5 +1,5 @@ | |||
| // this needs to be updated whenever there's a change to globalThis.Netlify in bootstrap | |||
| import { Netlify } from "https://64e8753eae24930008fac6d9--edge.netlify.app/bootstrap/index-combined.ts" | |||
| import { Netlify } from "https://68945e2afae503000862a504--edge.netlify.app/bootstrap/index-combined.ts" | |||
There was a problem hiding this comment.
Not ideal, but should we use getURL helper from edge-functions-bootstrap package to get bootstrap url? Afaik it provides branch urls (derived from package version name) and last deploys on branch deploys should never get deleted given our current soft deletion logic?
There was a problem hiding this comment.
Oh nvm just noticed this change is superseded by #6609 (review).
|
Closing (again) in favour of #6609! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're referencing a deploy that has been deleted.